lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240902085657.GE23170@kernel.org>
Date: Mon, 2 Sep 2024 09:56:57 +0100
From: Simon Horman <horms@...nel.org>
To: Yuesong Li <liyuesong@...o.com>
Cc: elder@...nel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, lihongbo22@...wei.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	opensource.kernel@...o.com
Subject: Re: [PATCH net-next v2] net: ipa: make use of dev_err_cast_probe()

On Thu, Aug 29, 2024 at 11:07:39AM +0800, Yuesong Li wrote:
> Using dev_err_cast_probe() to simplify the code.
> 
> Signed-off-by: Yuesong Li <liyuesong@...o.com>
> Signed-off-by: Hongbo Li <lihongbo22@...wei.com>
> ---
> v2: https://lore.kernel.org/all/20240828160728.GR1368797@kernel.org/
>   - fix patch name
>   - drop the {} and fix the alignment

Thanks for hte updates.

I note that this code is in a probe function,
so this patch is an appropriate use of dev_err_cast_probe() [1].

I also see that it addresses the feedback on code style from v1.

Reviewed-by: Simon Horman <horms@...nel.org>


[1] [PATCH] net: alacritech: Partially revert "net: alacritech: Switch to use dev_err_probe()"
    https://lore.kernel.org/netdev/20240830170014.15389-1-krzysztof.kozlowski@linaro.org/

...

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ