linux-kernel - Re: [PATCH v3 8/9] reset: amlogic: split the device core and platform probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1jbk16s7oo.fsf@starbuckisacylon.baylibre.com>
Date: Mon, 02 Sep 2024 11:53:27 +0200
From: Jerome Brunet <jbrunet@...libre.com>
To: Philipp Zabel <p.zabel@...gutronix.de>
Cc: Neil Armstrong <neil.armstrong@...aro.org>,  Stephen Boyd
 <sboyd@...nel.org>,  linux-kernel@...r.kernel.org,
  linux-amlogic@...ts.infradead.org,  linux-clk@...r.kernel.org
Subject: Re: [PATCH v3 8/9] reset: amlogic: split the device core and
 platform probe

On Mon 02 Sep 2024 at 11:47, Philipp Zabel <p.zabel@...gutronix.de> wrote:

> On Mo, 2024-08-19 at 18:49 +0200, Jerome Brunet wrote:
>> On Mon 19 Aug 2024 at 18:33, Neil Armstrong <neil.armstrong@...aro.org> wrote:
>> 
>> > On 08/08/2024 12:27, Jerome Brunet wrote:
>> > > To prepare the addition of the auxiliary device support, split
>> > > out the device core function from the probe of the platform device.
>> > > The device core function will be common to both the platform and
>> > > auxiliary
>> > > driver.
>> > > Signed-off-by: Jerome Brunet <jbrunet@...libre.com>
>> > > ---
>> > >   drivers/reset/amlogic/Kconfig                 |  10 +-
>> > >   drivers/reset/amlogic/Makefile                |   3 +-
>> > >   .../{reset-meson.c => reset-meson-core.c}     | 101 +++---------------
>> > >   drivers/reset/amlogic/reset-meson-pltf.c      |  92 ++++++++++++++++
>> > 
>> > Are we still in 1983 ?
>> 
>> I don't quite get that remark or how it is helping the review.
>>
>> > please use reset-meson-platform and drop pltf completely
>> 
>> You are requesting auxiliary -> aux on the patch.
>> So which one will it be ?
>
> I would prefer to drop the -pltf suffix completely and also to drop the
> "reset driver" -> "reset platform driver" documentation changes.

Hi Philipp,

I'm not sure what you mean with the last documentation bit ? Could you add some
details, I'd like to get the next version right.

Thanks 

>
> regards
> Philipp

-- 
Jerome