[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <96b95366-ebbc-444e-ae77-ccfe87a10dd5@redhat.com>
Date: Mon, 2 Sep 2024 12:02:35 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
David.Laight@...LAB.COM, Mauro Carvalho Chehab <mchehab@...nel.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
linux-media@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] media: atomisp: Use clamp_t() in
ia_css_eed1_8_vmem_encode()
Hi,
On 7/27/24 2:51 PM, Christophe JAILLET wrote:
> Using clamp_t() instead of min_t(max_t()) is easier to read.
>
> It also reduces the size of the preprocessed files by ~ 193 ko.
> (see [1] for a discussion about it)
>
> $ ls -l ia_css_eed1_8.host*.i
> 4829993 27 juil. 14:36 ia_css_eed1_8.host.old.i
> 4636649 27 juil. 14:42 ia_css_eed1_8.host.new.i
>
> [1]: https://lore.kernel.org/all/23bdb6fc8d884ceebeb6e8b8653b8cfe@AcuMS.aculab.com/
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Thank you for your patch(es).
I have merged this/these in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp
And this/these will be included in my next pull-request to
Mauro (to media subsystem maintainer)
Regards,
Hans
> ---
> .../isp/kernels/eed1_8/ia_css_eed1_8.host.c | 24 +++++++++----------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c
> index e4fc90f88e24..96c13ebc4331 100644
> --- a/drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c
> +++ b/drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c
> @@ -172,25 +172,25 @@ ia_css_eed1_8_vmem_encode(
> base = shuffle_block * i;
>
> for (j = 0; j < IA_CSS_NUMBER_OF_DEW_ENHANCE_SEGMENTS; j++) {
> - to->e_dew_enh_x[0][base + j] = min_t(int, max_t(int,
> - from->dew_enhance_seg_x[j], 0),
> - 8191);
> - to->e_dew_enh_y[0][base + j] = min_t(int, max_t(int,
> - from->dew_enhance_seg_y[j], -8192),
> - 8191);
> + to->e_dew_enh_x[0][base + j] = clamp_t(int,
> + from->dew_enhance_seg_x[j],
> + 0, 8191);
> + to->e_dew_enh_y[0][base + j] = clamp_t(int,
> + from->dew_enhance_seg_y[j],
> + -8192, 8191);
> }
>
> for (j = 0; j < (IA_CSS_NUMBER_OF_DEW_ENHANCE_SEGMENTS - 1); j++) {
> - to->e_dew_enh_a[0][base + j] = min_t(int, max_t(int,
> - from->dew_enhance_seg_slope[j],
> - -8192), 8191);
> + to->e_dew_enh_a[0][base + j] = clamp_t(int,
> + from->dew_enhance_seg_slope[j],
> + -8192, 8191);
> /* Convert dew_enhance_seg_exp to flag:
> * 0 -> 0
> * 1...13 -> 1
> */
> - to->e_dew_enh_f[0][base + j] = (min_t(int, max_t(int,
> - from->dew_enhance_seg_exp[j],
> - 0), 13) > 0);
> + to->e_dew_enh_f[0][base + j] = (clamp_t(int,
> + from->dew_enhance_seg_exp[j],
> + 0, 13) > 0);
> }
>
> /* Hard-coded to 0, in order to be able to handle out of
Powered by blists - more mailing lists