linux-kernel - Re: [PATCH] media: atomisp: Fix trailing statement in ia_css

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d6724490-1f43-4bbd-a80f-575aa31af47f@redhat.com>
Date: Mon, 2 Sep 2024 12:10:18 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Kathara Sasikumar <katharasasikumar007@...il.com>
Cc: ~lkcamp/patches@...ts.sr.ht, mchehab@...nel.org,
 sakari.ailus@...ux.intel.com, gregkh@...uxfoundation.org,
 linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org, helen.koike@...labora.com
Subject: Re: [PATCH] media: atomisp: Fix trailing statement in
 ia_css_de.host.c

Hi,

On 7/30/24 10:27 AM, Kathara Sasikumar wrote:
> Fix checkpatch diagostic of Error : Trailing statements should be on the
> next line
> 
> Signed-off-by: Kathara Sasikumar <katharasasikumar007@...il.com>

Thank you for your patch(es).

I have merged this/these in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this/these will be included in my next pull-request to
Mauro (to media subsystem maintainer)

Regards,

Hans


> ---
> Hi,  
> 
> This is my first patch for the kernel. 
> Big thanks to Helen Koike for the guidance 
> at her Debconf24 workshop.
> 
> Thank you,
> Kathara
>  .../media/atomisp/pci/isp/kernels/de/de_1.0/ia_css_de.host.c   | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/de/de_1.0/ia_css_de.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/de/de_1.0/ia_css_de.host.c
> index 25e3f0822..e66faeda3 100644
> --- a/drivers/staging/media/atomisp/pci/isp/kernels/de/de_1.0/ia_css_de.host.c
> +++ b/drivers/staging/media/atomisp/pci/isp/kernels/de/de_1.0/ia_css_de.host.c
> @@ -47,7 +47,8 @@ ia_css_de_dump(
>      const struct sh_css_isp_de_params *de,
>      unsigned int level)
>  {
> -	if (!de) return;
> +	if (!de)
> +		return;
>  	ia_css_debug_dtrace(level, "Demosaic:\n");
>  	ia_css_debug_dtrace(level, "\t%-32s = %d\n",
>  			    "de_pixelnoise", de->pixelnoise);