linux-kernel - Re: [PATCH] media: atomisp: move trailing statement to next line.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <389b81a7-a7be-48c0-adc0-40d313a38c5d@redhat.com>
Date: Mon, 2 Sep 2024 12:10:41 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Sakirnth Nagarasa <sakirnth@...il.com>, mchehab@...nel.org,
 sakari.ailus@...ux.intel.com, gregkh@...uxfoundation.org,
 linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Cc: ~lkcamp/patches@...ts.sr.ht, helen.koike@...labora.com
Subject: Re: [PATCH] media: atomisp: move trailing statement to next line.

Hi,

On 7/30/24 10:42 AM, Sakirnth Nagarasa wrote:
> Fix checkpath error "ERROR: trailing statements should be on next line"
> in ia_css_fpn.host.c:46.
> 
> Signed-off-by: Sakirnth Nagarasa <sakirnth@...il.com>


Thank you for your patch(es).

I have merged this/these in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this/these will be included in my next pull-request to
Mauro (to media subsystem maintainer)

Regards,

Hans




> ---
> 
> Hello, this is my first patch to the kernel.
> ---
>  .../atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c      | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c
> index 57b5e11e1..8ccfa99c6 100644
> --- a/drivers/staging/media/atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c
> +++ b/drivers/staging/media/atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c
> @@ -43,7 +43,8 @@ ia_css_fpn_dump(
>      const struct sh_css_isp_fpn_params *fpn,
>      unsigned int level)
>  {
> -	if (!fpn) return;
> +	if (!fpn)
> +		return;
>  	ia_css_debug_dtrace(level, "Fixed Pattern Noise Reduction:\n");
>  	ia_css_debug_dtrace(level, "\t%-32s = %d\n",
>  			    "fpn_shift", fpn->shift);