linux-kernel - Re: [PATCH] media: atomisp: move trailing */ to separate lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52a23d6c-b50c-4079-b0e7-4c1ca2fbc394@redhat.com>
Date: Mon, 2 Sep 2024 12:10:58 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Sergio de Almeida Cipriano Junior <sergiosacj@...eup.net>
Cc: ~lkcamp/patches@...ts.sr.ht, mchehab@...nel.org,
 sakari.ailus@...ux.intel.com, gregkh@...uxfoundation.org,
 linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org, helen.koike@...labora.com
Subject: Re: [PATCH] media: atomisp: move trailing */ to separate lines

Hi,

On 7/30/24 9:19 AM, Sergio de Almeida Cipriano Junior wrote:
> Fix checkpatch diagnostic "WARNING: Block comments use a trailing */ on
> a separate line" in assert_support.h file.
> 
> Signed-off-by: Sergio de Almeida Cipriano Junior <sergiosacj@...eup.net>

Thank you for your patch(es).

I have merged this/these in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this/these will be included in my next pull-request to
Mauro (to media subsystem maintainer)

Regards,

Hans





> ---
> Hi, this is my first patch to the kernel.
> ---
>  .../media/atomisp/pci/hive_isp_css_include/assert_support.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_include/assert_support.h b/drivers/staging/media/atomisp/pci/hive_isp_css_include/assert_support.h
> index d294ac402..c5ab13511 100644
> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_include/assert_support.h
> +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_include/assert_support.h
> @@ -27,7 +27,8 @@
>   * #define assert(cnd) BUG_ON(cnd)
>   * but that causes many compiler warnings (==errors) under Android
>   * because it seems that the BUG_ON() macro is not seen as a check by
> - * gcc like the BUG() macro is. */
> + * gcc like the BUG() macro is.
> + */
>  #define assert(cnd) \
>  	do { \
>  		if (!(cnd)) \
> @@ -37,7 +38,8 @@
>  #ifndef PIPE_GENERATION
>  /* Deprecated OP___assert, this is still used in ~1000 places
>   * in the code. This will be removed over time.
> - * The implementation for the pipe generation tool is in see support.isp.h */
> + * The implementation for the pipe generation tool is in see support.isp.h
> + */
>  #define OP___assert(cnd) assert(cnd)
>  
>  static inline void compile_time_assert(unsigned int cond)