linux-kernel - Re: [PATCH v2] staging: atomisp: bnr: fix trailing statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65d131fe-952e-45f7-9284-652c23b6abb6@redhat.com>
Date: Mon, 2 Sep 2024 12:11:16 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Kartik Kulkarni <kartik.koolks@...il.com>, mchehab@...nel.org,
 akari.ailus@...ux.intel.com, gregkh@...uxfoundation.org,
 linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Cc: ~lkcamp/patches@...ts.sr.ht, helen.koike@...labora.com
Subject: Re: [PATCH v2] staging: atomisp: bnr: fix trailing statement

Hi,

On 7/31/24 12:33 PM, Kartik Kulkarni wrote:
> Fix checkpatch error trailing statements should be on next line in
> ia_css_bnr.host.c:48
> 
> Signed-off-by: Kartik Kulkarni <kartik.koolks@...il.com>

Thank you for your patch(es).

I have merged this/these in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this/these will be included in my next pull-request to
Mauro (to media subsystem maintainer)

Regards,

Hans




> ---
> v2: Move Signed-off-by line above the exclusion block
> ---
>  .../atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c      | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c
> index 457a004e1..b75cfd309 100644
> --- a/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c
> +++ b/drivers/staging/media/atomisp/pci/isp/kernels/bnr/bnr_1.0/ia_css_bnr.host.c
> @@ -45,7 +45,8 @@ ia_css_bnr_dump(
>      const struct sh_css_isp_bnr_params *bnr,
>      unsigned int level)
>  {
> -	if (!bnr) return;
> +	if (!bnr)
> +		return;
>  	ia_css_debug_dtrace(level, "Bayer Noise Reduction:\n");
>  	ia_css_debug_dtrace(level, "\t%-32s = %d\n",
>  			    "bnr_gain_all", bnr->gain_all);