linux-kernel - Re: iio: imu: inv_mpu6050: Remove duplicate code between labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240902113613.0000183e@Huawei.com>
Date: Mon, 2 Sep 2024 11:36:13 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>
CC: Markus Elfring <Markus.Elfring@....de>, Gyeyoung Baek <gye976@...il.com>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>, Jonathan Cameron
	<jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, LKML
	<linux-kernel@...r.kernel.org>
Subject: Re: iio: imu: inv_mpu6050: Remove duplicate code between labels

On Mon, 2 Sep 2024 09:54:14 +0000
Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com> wrote:

> Hello,
> 
> beware this patch is buggy. It will break the IRQ handler function of inv_mpu6050 driver.
> 
> The normal code path is going through end_session label without goto, and expect the function return before executing inv_reset_fifo. Without it, the reset FIFO function will be called for every interrupt and is breaking normal functioning of the driver.

Doh.  Indeed.  I missed that entirely by focusing on the error paths, not the good one.


> 
> Best regards,
> JB
> 
> ________________________________________
> From: Markus Elfring <Markus.Elfring@....de>
> Sent: Monday, September 2, 2024 08:00
> To: Gyeyoung Baek <gye976@...il.com>; linux-iio@...r.kernel.org <linux-iio@...r.kernel.org>; Jonathan Cameron <jic23@...nel.org>; Lars-Peter Clausen <lars@...afoo.de>
> Cc: LKML <linux-kernel@...r.kernel.org>
> Subject: Re: iio: imu: inv_mpu6050: Remove duplicate code between labels
>  
> This Message Is From an Untrusted Sender
> You have not previously corresponded with this sender.
>  
> >>> Hello, I apologize for the insufficient explanation.  
> >>
> >> How will the commit message be improved further?  
> …
> > Since the code is short,  
> 
> This implementation detail can be nice.
> 
> 
> > I think it's fine for now.  
> 
> Please reconsider such a view once more.
> Are imperative wordings also more desirable for a better change description?
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc6*n45__;Iw!!FtrhtPsWDhZ6tw!Hb9yipjKJXmB-DO9gWKADZfQZHI84WEFUc6Ns1iGhpAfvAAyjrnLQRJZLU2Ha0nI8Fs-HBqHFlFbq0Kl-O1CJwYLe776xbRywQ$[git[.]kernel[.]org]
> 
> Regards,
> Markus
> 
>