linux-kernel - Re: [PATCH v1] thermal: brcmstb_thermal: Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b4fc2024-84cd-4b10-b974-9886421b536f@linaro.org>
Date: Mon, 2 Sep 2024 13:10:13 +0200
From: Daniel Lezcano <daniel.lezcano@...aro.org>
To: Yan Zhen <yanzhen@...o.com>, mmayer@...adcom.com, rafael@...nel.org,
 florian.fainelli@...adcom.com
Cc: bcm-kernel-feedback-list@...adcom.com, rui.zhang@...el.com,
 lukasz.luba@....com, linux-pm@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 opensource.kernel@...o.com
Subject: Re: [PATCH v1] thermal: brcmstb_thermal: Simplify with
 dev_err_probe()

On 30/08/2024 12:39, Yan Zhen wrote:
> dev_err_probe() is used to log an error message during the probe process
> of a device.
> 
> It can simplify the error path and unify a message template.
> 
> Using this helper is totally fine even if err is known to never
> be -EPROBE_DEFER.
> 
> The benefit compared to a normal dev_err() is the standardized format
> of the error code, it being emitted symbolically and the fact that
> the error code is returned which allows more compact error paths.
> 
> Signed-off-by: Yan Zhen <yanzhen@...o.com>
> ---

Applied, thanks


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog