linux-kernel - Re: [PATCH] iio: imu: inv_mpu6050: Remove duplicate code between labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKbEznv+2u_QV8+P+dYN_UygKm2PhzgVgTM+uEH9crPRQ4a8vw@mail.gmail.com>
Date: Mon, 2 Sep 2024 20:15:45 +0900
From: gyeyoung <gye976@...il.com>
To: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>
Cc: Markus Elfring <Markus.Elfring@....de>, 
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>, Jonathan Cameron <jic23@...nel.org>, 
	Lars-Peter Clausen <lars@...afoo.de>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: imu: inv_mpu6050: Remove duplicate code between labels

On Mon, Sep 2, 2024 at 7:04 PM Jean-Baptiste Maneyrol
<Jean-Baptiste.Maneyrol@....com> wrote:
>
> Hello,
>
> it would be true if there was a return statement before the 2 labels, and that the 2 lables were only error handling case.
>
> But this is not the case, since end_session label is the end of the normal end of the function, not error handling. This is very old code and not very clear, I'm sorry about that.
>
> But the modifications are breaking the code and interrupt handling will not work correctly anymore, since inv_reset_fifo() will be called now every time the function is called.
>
> Best regards,
> JB

I apologize for the confusion, I just realized the logic is incorrect
as well. I didn't test it because I thought it trivial, I will send
patch after verification.