linux-kernel - Re: [PATCH v2] drivers: spi: Insert the missing pci_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <116033b0-a701-40ef-a5ab-a2d46885872b@sirena.org.uk>
Date: Mon, 2 Sep 2024 12:48:37 +0100
From: Mark Brown <broonie@...nel.org>
To: Nathan Chancellor <nathan@...nel.org>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>,
	Yang Ruibin <11162571@...o.com>, Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	linux-arm-kernel@...ts.infradead.org, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org, opensource.kernel@...o.com,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v2] drivers: spi: Insert the missing pci_dev_put()before
 return

On Fri, Aug 30, 2024 at 03:23:32PM -0700, Nathan Chancellor wrote:
> On Fri, Aug 30, 2024 at 08:57:47PM +0100, Mark Brown wrote:

> > I'm a bit concerned that this isn't picked up by an allmodconfig with
> > the -Werror...  I'm currently using GCC 12 for that.
> 
> It shows up with -Wmaybe-uninitialized for GCC but that's disabled for
> the normal kernel build with commit 78a5255ffb6a ("Stop the ad-hoc games
> with -Wno-maybe-initialized"). With GCC 12:

...

> Perhaps a KCFLAGS=-Wmaybe-uninitialized in your make command or adding
> 
>   subdir-ccflags-$(CONFIG_CC_IS_GCC) := -Wmaybe-uninitialized
> 
> to the makefiles of the drivers that you maintain might not be a bad
> idea.

If it's causing so many false positives that it's been disabled then
that'll just cause trouble, it's always miserable whenever a subsystem
decides to go with custom warning options.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)