linux-kernel - Re: [PATCH -next] printk: Use the BITS_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y14auulz.fsf@jogness.linutronix.de>
Date: Mon, 02 Sep 2024 14:13:36 +0206
From: John Ogness <john.ogness@...utronix.de>
To: Jinjie Ruan <ruanjinjie@...wei.com>, pmladek@...e.com,
 rostedt@...dmis.org, senozhatsky@...omium.org,
 linux-kernel@...r.kernel.org
Cc: ruanjinjie@...wei.com
Subject: Re: [PATCH -next] printk: Use the BITS_PER_LONG macro

On 2024-09-02, Jinjie Ruan <ruanjinjie@...wei.com> wrote:
> sizeof(unsigned long) * 8 is the number of bits in an unsigned long
> variable, replace it with BITS_PER_LONG macro to make it simpler.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> ---
>  kernel/printk/printk_ringbuffer.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/printk/printk_ringbuffer.h b/kernel/printk/printk_ringbuffer.h
> index bd2a892deac1..7433fe477e08 100644
> --- a/kernel/printk/printk_ringbuffer.h
> +++ b/kernel/printk/printk_ringbuffer.h
> @@ -122,7 +122,7 @@ enum desc_state {
>  
>  #define _DATA_SIZE(sz_bits)	(1UL << (sz_bits))
>  #define _DESCS_COUNT(ct_bits)	(1U << (ct_bits))
> -#define DESC_SV_BITS		(sizeof(unsigned long) * 8)
> +#define DESC_SV_BITS		BITS_PER_LONG

We should also add:

#include <linux/bits.h>

John Ogness