linux-kernel - Re: [PATCH v5 1/2] mtd: spinand: Add support for setting plane select bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240902142853.5fff056a@xps-13>
Date: Mon, 2 Sep 2024 14:28:53 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Cheng Ming Lin <linchengming884@...il.com>
Cc: vigneshr@...com, linux-mtd@...ts.infradead.org,
 linux-kernel@...r.kernel.org, richard@....at, alvinzhou@...c.com.tw,
 leoyu@...c.com.tw, Cheng Ming Lin <chengminglin@...c.com.tw>
Subject: Re: [PATCH v5 1/2] mtd: spinand: Add support for setting plane
 select bits

Hi Cheng,

linchengming884@...il.com wrote on Mon, 2 Sep 2024 16:42:55 +0800:

> Hi Miquel,
> 
> I accidentally sent the previous email before it was finished.
> 
> Miquel Raynal <miquel.raynal@...tlin.com> 於 2024年8月30日 週五 下午11:55寫道：
> >
> > Hi ChengMing,
> >
> > linchengming884@...il.com wrote on Fri, 30 Aug 2024 18:03:09 +0800:
> >  
> > > From: Cheng Ming Lin <chengminglin@...c.com.tw>
> > >
> > > Add two flags for inserting the Plane Select bit into the column
> > > address during the write_to_cache and the read_from_cache operation.
> > >
> > > Add the SPINAND_HAS_PP_PLANE_SELECT_BIT flag for serial NAND flash  
> >
> > This flag has been renamed :)  
> 
> Thank you for the reminder. I will make the necessary changes.
> 
> >  
> > > that require inserting the Plane Select bit into the column address
> > > during the write_to_cache operation.
> > >
> > > Add the SPINAND_HAS_READ_PLANE_SELECT_BIT flag for serial NAND flash
> > > that require inserting the Plane Select bit into the column address
> > > during the read_from_cache operation.
> > >
> > > Signed-off-by: Cheng Ming Lin <chengminglin@...c.com.tw>
> > > ---
> > >  drivers/mtd/nand/spi/core.c | 6 ++++++
> > >  include/linux/mtd/spinand.h | 2 ++
> > >  2 files changed, 8 insertions(+)
> > >
> > > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
> > > index e0b6715e5dfe..e7b592cdbb4c 100644
> > > --- a/drivers/mtd/nand/spi/core.c
> > > +++ b/drivers/mtd/nand/spi/core.c
> > > @@ -386,6 +386,9 @@ static int spinand_read_from_cache_op(struct spinand_device *spinand,
> > >       else
> > >               rdesc = spinand->dirmaps[req->pos.plane].rdesc_ecc;
> > >
> > > +     if (spinand->flags & SPINAND_HAS_READ_PLANE_SELECT_BIT)
> > > +             column |= req->pos.plane << fls(nanddev_page_size(nand));  
> >
> > Isn't there any better way to know what the bit position is?  
> 
> There are two other methods to determine the bit position:
> - column |= res->pos.plane << fls(nand->memorg.pagesize)
> - column |= wdesc->info.offset

Ok, let's keep it is as-is for now.

Thanks,
Miquèl