linux-kernel - Re: [PATCH] selftests: vDSO: Do not rely on $ARCH for vdso_test_getrandom && vdso_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec7bfeb4-30aa-4874-98b7-7877a12cb98f@sirena.org.uk>
Date: Mon, 2 Sep 2024 13:37:12 +0100
From: Mark Brown <broonie@...nel.org>
To: Christophe Leroy <christophe.leroy@...roup.eu>
Cc: "Jason A. Donenfeld" <Jason@...c4.com>, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org,
	Adhemerval Zanella <adhemerval.zanella@...aro.org>,
	Xi Ruoyao <xry111@...111.site>
Subject: Re: [PATCH] selftests: vDSO: Do not rely on $ARCH for
 vdso_test_getrandom && vdso_test_chacha

On Mon, Sep 02, 2024 at 02:22:38PM +0200, Christophe Leroy wrote:

> When vdso_test_getcpu doesn't find the vDSO entry point, it prints an error
> text and returns KSFT_SKIP

> I thought it would be more correct to have the same behaviour on
> vdso_test_getrandom instead of trying to build it only when the underlying
> kernel supports it.

The problem is that the test incorporates assembler code so it simply
won't build for architectures without explicit porting, the issue isn't
if the target kernel supports it but rather that the test won't compile
in the first place.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)