linux-kernel - Re: [syzbot] possible fix 2 (linux-ntfs3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000000000000fcbfb30621224b65@google.com>
Date: Mon, 02 Sep 2024 05:44:07 -0700
From: syzbot <syzbot+4d2aaeff9eb5a2cfec70@...kaller.appspotmail.com>
To: linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] possible fix 2 (linux-ntfs3)

For archival purposes, forwarding an incoming command email to
linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com.

***

Subject: possible fix 2 (linux-ntfs3)
Author: almaz.alexandrovich@...agon-software.com

#syz test: https://github.com/Paragon-Software-Group/linux-ntfs3.git master

diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 128d49512f5d..c08bbacc0030 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -125,8 +125,9 @@ void ntfs_inode_printk(struct inode *inode, const char *fmt, ...)
 
 		if (de) {
 			spin_lock(&de->d_lock);
-			snprintf(name, sizeof(s_name_buf), " \"%s\"",
-				 de->d_name.name);
+			if (snprintf(name, sizeof(s_name_buf), " \"%s\"",
+				     de->d_name.name) >= sizeof(s_name_buf))
+				name[sizeof(s_name_buf) - 1] = 0;
 			spin_unlock(&de->d_lock);
 		} else {
 			name[0] = 0;