linux-kernel - Re: [PATCH net-next v3 3/6] net: ti: icssg-prueth: Add support for HSR frame forward offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2598368-745f-4a83-abfc-b9609ebff6b0@lunn.ch>
Date: Mon, 2 Sep 2024 15:02:49 +0200
From: Andrew Lunn <andrew@...n.ch>
To: "Anwar, Md Danish" <a0501179@...com>
Cc: Roger Quadros <rogerq@...nel.org>, MD Danish Anwar <danishanwar@...com>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	Jan Kiszka <jan.kiszka@...mens.com>,
	Javier Carrasco <javier.carrasco.cruz@...il.com>,
	Jacob Keller <jacob.e.keller@...el.com>,
	Diogo Ivo <diogo.ivo@...mens.com>, Simon Horman <horms@...nel.org>,
	Richard Cochran <richardcochran@...il.com>,
	Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, srk@...com,
	Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH net-next v3 3/6] net: ti: icssg-prueth: Add support for
 HSR frame forward offload

> Yes, and I have already added this in this series based on your feedback
> on v2.
> 
> I have one question though, in emac_ndo_set_features() should I change
> these HSR related features irrespective of the current mode?
> 
> AFAIK, if NETIF_F_HW_HSR_FWD is set, the forwarding is offloaded to HW.
> If NETIF_F_HW_HSR_FWD is not set the forwarding is not offloaded to HW
> and is done in SW.
> 
> So, I don't see any need to enable this features if we are currently in
> switch mode. Let me know what do you think. Should I still enable this
> feature irrespective of current mode and later handle this in
> prueth_hsr_port_link / unlink()?

The user should not need to know about the different firmwares. So i
would allow NETIF_F_HW_HSR_FWD at any time.

The exception would be, if you look at all the other drivers which
implement HSR offload, if they all return an error if the offloading
cannot be enabled, then you should do the same.

	Andrew