linux-kernel - Re: [PATCH v2] iio: imu: inv_mpu6050: Remove duplicate code between labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25f3cbe5-1491-4f50-9971-d251c407879f@web.de>
Date: Mon, 2 Sep 2024 15:35:37 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen
 <lars@...afoo.de>, linux-iio@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Gyeyoung Baek <gye976@...il.com>,
 Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@....com>
Subject: Re: [PATCH v2] iio: imu: inv_mpu6050: Remove duplicate code between
 labels

> > 'flush_fifo' label performs same task as 'endsession' label
> > immediately after calling 'env_reset_fifo' function.
> > So i remove that duplication.
…
> Ok. This doesn't greatly affect readability and the code
> ends up a bit shorter.

How can you find such a change description acceptable?


> Applied

Please reconsider this positive feedback once more.

It temporarily looked too promising to apply a goto chain.
But the original control flow needs other development considerations
if you would like to reduce the explicit repetition of common actions.

Regards,
Markus