linux-kernel - Re: [PATCH v9 1/3] perf report: Support LLVM for addr2line()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtcLz45rJYJR7FCQ@x1>
Date: Tue, 3 Sep 2024 10:14:55 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: "Steinar H. Gunderson" <sesse@...gle.com>
Cc: linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	irogers@...gle.com, Arnaldo Carvalho de Melo <acme@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH v9 1/3] perf report: Support LLVM for addr2line()

On Tue, Sep 03, 2024 at 07:09:47AM -0300, Arnaldo Carvalho de Melo wrote:
> On Sun, Sep 01, 2024 at 12:57:25PM +0200, Steinar H. Gunderson wrote:
> > On Tue, Jul 30, 2024 at 04:49:12PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Unfortunately it clashed with recent patches in the capstone related
> > > codebase, IIRC Athira's for powerpc data-type profiling.
> > > 
> > > […]
> > > 
> > > I'll continue processing other patched and eventually try to fix this if
> > > you're busy,
> > 
> > Hi,
> > 
> > Is there any movement in getting v10 merged? :-) I haven't heard back
> > since I sent out the rebase
> 
> Test building is detecting some problems, I'll try to address them:
> 
> perfbuilder@...ber:~$ time dm
>    1    13.50 almalinux:8                   : FAIL gcc version 8.5.0 20210514 (Red Hat 8.5.0-22) (GCC) 
>     util/srcline.c: In function 'dso__free_a2l':
>     util/srcline.c:184:20: error: parameter name omitted
>      void dso__free_a2l(struct dso *)
>                         ^~~~~~~~~~~~
>     make[3]: *** [/git/perf-6.11.0-rc3/tools/build/Makefile.build:158: util] Error 2

diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c
index 2e3845ac07ee7be6..f32d0d4f4bc9e659 100644
--- a/tools/perf/util/srcline.c
+++ b/tools/perf/util/srcline.c
@@ -6,6 +6,7 @@
 #include <string.h>
 #include <sys/types.h>
 
+#include <linux/compiler.h>
 #include <linux/kernel.h>
 #include <linux/string.h>
 #include <linux/zalloc.h>
@@ -181,7 +182,7 @@ static int addr2line(const char *dso_name, u64 addr,
 	return num_frames;
 }
 
-void dso__free_a2l(struct dso *)
+void dso__free_a2l(struct dso *dso __maybe_unused)
 {
 	/* Nothing to free. */
 }