linux-kernel - Re: [PATCH] uprobes: use kzalloc to allocate xol area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240903131931.GU4723@noisy.programming.kicks-ass.net>
Date: Tue, 3 Sep 2024 15:19:31 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Oleg Nesterov <oleg@...hat.com>
Cc: Sven Schnelle <svens@...ux.ibm.com>, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	"Liang, Kan" <kan.liang@...ux.intel.com>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH] uprobes: use kzalloc to allocate xol area

On Tue, Sep 03, 2024 at 02:46:07PM +0200, Oleg Nesterov wrote:
> On 09/03, Sven Schnelle wrote:
> >
> > To prevent unitialized members, use kzalloc to allocate
> > the xol area.
> >
> > Signed-off-by: Sven Schnelle <svens@...ux.ibm.com>
> 
> Acked-by: Oleg Nesterov <oleg@...hat.com>
> 
> and since this looks easily exploitable, I'd sugest
> 
> Cc: stable@...r.kernel.org
> Fixes: b059a453b1cf1 ("x86/vdso: Add mremap hook to vm_special_mapping")

Thanks, will queue in perf/urgent