linux-kernel - Re: [PATCH v8 0/8] Add QPIC SPI NAND driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fed18a8f-446f-4d61-a9ce-4c5e09bf0aaa@kernel.org>
Date: Tue, 3 Sep 2024 15:44:41 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Md Sadre Alam <quic_mdalam@...cinc.com>, broonie@...nel.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 andersson@...nel.org, konradybcio@...nel.org, miquel.raynal@...tlin.com,
 richard@....at, vigneshr@...com, manivannan.sadhasivam@...aro.org,
 esben@...nix.com, linux-arm-msm@...r.kernel.org, linux-spi@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v8 0/8] Add QPIC SPI NAND driver

On 03/09/2024 11:15, Md Sadre Alam wrote:
> Hi Miquel,
> 
> On 8/20/2024 4:12 PM, Md Sadre Alam wrote:
>> v8:
>>   * Fixed compilation warning reported by kernel test robot
>>   * Added "chip" description in nandc_set_read_loc_first()
>>   * Added "chip" description" in nandc_set_read_loc_last()
>>   * Changed data type of read_location0, read_location1,
>>     read_location2, read_location3, addr0, addr1, cmd, cfg0,
>>     cfg1, ecc_bch_cfg, ecc_buf_cfg, clrflashstatus, clrreadstatus,
>>     orig_cmd1, orig_vld to __le32 to fix compilation warning.
>>   * Included bitfield.h header file in spi-qpic-snand.c to
>>     fix compilation warning
>>   * Removed unused variable "steps" variable from
>>     qcom_spi_ecc_init_ctx_pipelined()
>>
>      I have addressed your comments to v6 and further posted till v8.
>      Could you please let me know if this is fine.
>      and how to get this merged ?

Two weeks ago you received reports that your code does not build
properly. So no, it is not fine. Please respond to the reports and/or
send corrected code.

Best regards,
Krzysztof