linux-kernel - Re: [PATCH v2 2/3] rtc: support for the Amlogic on-chip RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7560bdd0-aafc-4c6a-b5a8-f50e9aa3124b@kernel.org>
Date: Tue, 3 Sep 2024 16:04:25 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: xianwei.zhao@...ogic.com, Yiting Deng <yiting.deng@...ogic.com>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-amlogic@...ts.infradead.org, linux-rtc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] rtc: support for the Amlogic on-chip RTC

On 03/09/2024 09:00, Xianwei Zhao via B4 Relay wrote:
> From: Yiting Deng <yiting.deng@...ogic.com>
> 

...

> +	rtc->map = devm_regmap_init_mmio(&pdev->dev, base, &aml_rtc_regmap_config);
> +	if (IS_ERR(rtc->map)) {
> +		dev_err_probe(&pdev->dev, PTR_ERR(rtc->map), "regmap init failed\n");
> +		return PTR_ERR(rtc->map);

Nothing improved. Read the comment. Use git grep to see how this is done
if the comment is somehow unclear.

<form letter>
This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.
</form letter>

Best regards,
Krzysztof