linux-kernel - Re: [PATCH V6 net-next 03/11] net: hibmcge: Add mdio and hardware configuration supported in this module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08462a25-ddd0-4f78-a373-14b822bd7706@huawei.com>
Date: Tue, 3 Sep 2024 22:42:30 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Andrew Lunn <andrew@...n.ch>
CC: <shaojijie@...wei.com>, Paolo Abeni <pabeni@...hat.com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<shenjian15@...wei.com>, <wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>,
	<chenhao418@...wei.com>, <sudongming1@...wei.com>, <xujunsheng@...wei.com>,
	<shiyongbang@...wei.com>, <libaihan@...wei.com>, <jdamato@...tly.com>,
	<horms@...nel.org>, <jonathan.cameron@...wei.com>,
	<shameerali.kolothum.thodi@...wei.com>, <salil.mehta@...wei.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V6 net-next 03/11] net: hibmcge: Add mdio and hardware
 configuration supported in this module


on 2024/9/3 21:15, Andrew Lunn wrote:
> On Tue, Sep 03, 2024 at 08:13:58PM +0800, Jijie Shao wrote:
>> on 2024/9/3 19:59, Paolo Abeni wrote:
>>> On 8/30/24 14:15, Jijie Shao wrote:
>>> [...]
>>>> +static int hbg_mdio_wait_ready(struct hbg_mac *mac)
>>>> +{
>>>> +#define HBG_MDIO_OP_TIMEOUT_US        (1 * 1000 * 1000)
>>>> +#define HBG_MDIO_OP_INTERVAL_US        (5 * 1000)
>>> Minor nit: I find the define inside the function body less readable than
>>> placing them just before the function itself.
>> These two macros are only used in this function.
>> Is it necessary to move them to the header file?
> Put them at the top of the .c file. That is pretty much standard in C.
>
> 	Andrew

ok， Thanks!