linux-kernel - [PATCH] iommu/vt-d: Fix 'Null pointer dereferences' issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240903144601.8149-1-qianqiang.liu@163.com>
Date: Tue,  3 Sep 2024 22:46:01 +0800
From: Qianqiang Liu <qianqiang.liu@....com>
To: dwmw2@...radead.org,
	baolu.lu@...ux.intel.com
Cc: iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Qianqiang Liu <qianqiang.liu@....com>
Subject: [PATCH] iommu/vt-d: Fix 'Null pointer dereferences' issue

Passing null pointer "pdev" to "pci_enable_pasid", which dereferences it.
Check the "pdev" is null or not before passing to "pci_enable_pasid".

Signed-off-by: Qianqiang Liu <qianqiang.liu@....com>
---
 drivers/iommu/intel/iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index 9f6b0780f2ef..a1e54f334330 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -3935,7 +3935,7 @@ static struct iommu_device *intel_iommu_probe_device(struct device *dev)
 	 * So always enable PASID support on devices which have it, even if
 	 * we can't yet know if we're ever going to use it.
 	 */
-	if (info->pasid_supported &&
+	if (info->pasid_supported && pdev &&
 	    !pci_enable_pasid(pdev, info->pasid_supported & ~1))
 		info->pasid_enabled = 1;
 
-- 
2.39.2