[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CALs4sv0s0=8Mg-5hQAeLEnTDfwKFy2esp9yFchX0kpPCEciNpA@mail.gmail.com>
Date: Tue, 3 Sep 2024 20:27:21 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Geetha sowjanya <gakula@...vell.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kuba@...nel.org,
davem@...emloft.net, pabeni@...hat.com, jiri@...nulli.us, edumazet@...gle.com,
sgoutham@...vell.com, sbhatta@...vell.com, hkelam@...vell.com
Subject: Re: [net-next PATCH 1/4] octeontx2-pf: Defines common API for HW
resources configuration
On Tue, Sep 3, 2024 at 6:11 PM Geetha sowjanya <gakula@...vell.com> wrote:
>
> -
> /* Assign default mac address */
> otx2_get_mac_from_af(netdev);
>
> @@ -3118,11 +3141,8 @@ static int otx2_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> if (test_bit(CN10K_LMTST, &pf->hw.cap_flag))
> qmem_free(pf->dev, pf->dync_lmt);
> otx2_detach_resources(&pf->mbox);
Isn't some of this unwinding/cleanup already moved to the new
function? Looks like duplicate code to me.
> -err_disable_mbox_intr:
> otx2_disable_mbox_intr(pf);
> -err_mbox_destroy:
> otx2_pfaf_mbox_destroy(pf);
> -err_free_irq_vectors:
> pci_free_irq_vectors(hw->pdev);
> err_free_netdev:
> pci_set_drvdata(pdev, NULL);
> --
> 2.25.1
>
>
Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)
Powered by blists - more mailing lists