linux-kernel - Re: [PATCH v7 00/21] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240903034542.GD9738@google.com>
Date: Tue, 3 Sep 2024 12:45:42 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Sergey Senozhatsky <senozhatsky@...omium.org>
Cc: alexs@...nel.org, Vitaly Wool <vitaly.wool@...sulko.com>,
	Miaohe Lin <linmiaohe@...wei.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	minchan@...nel.org, willy@...radead.org, david@...hat.com,
	42.hyeyoo@...il.com, Yosry Ahmed <yosryahmed@...gle.com>,
	nphamcs@...il.com
Subject: Re: [PATCH v7 00/21] mm/zsmalloc: add zpdesc memory descriptor for
 zswap.zpool

On (24/09/03 12:35), Sergey Senozhatsky wrote:
> On (24/09/02 15:21), alexs@...nel.org wrote:
> > The descriptor still overlays the struct page; nothing has changed
> > in that regard.
> > [..]
> > This patachset does not increase the descriptor size nor introduce any
> > functional changes, and could save about 122Kbytes zsmalloc.o size.
> 
> Is this number accurate?  Where does such a large saving come from?

./scripts/bloat-o-meter mm/zsmalloc.o-base mm/zsmalloc.o-patched
add/remove: 0/0 grow/shrink: 2/6 up/down: 7/-843 (-836)
Function                                     old     new   delta
obj_free                                     211     215      +4
zs_unmap_object                              568     571      +3
zs_map_object                                661     633     -28
SetZsPageMovable                             135      86     -49
free_zspage                                  310     253     -57
__free_zspage                                284     226     -58
zs_page_migrate                             1304    1136    -168
async_free_zspage                           1099     616    -483