linux-kernel - Re: [PATCH 11/22] pinctrl: qcom: sa8775p: Add support for SA8255p SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b855f1a9-35c2-4c53-9485-0989b3eb5a6b@quicinc.com>
Date: Tue, 3 Sep 2024 08:24:29 -0700
From: Nikunj Kela <quic_nkela@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: <andersson@...nel.org>, <konradybcio@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>, <rafael@...nel.org>,
        <viresh.kumar@...aro.org>, <herbert@...dor.apana.org.au>,
        <davem@...emloft.net>, <sudeep.holla@....com>, <andi.shyti@...nel.org>,
        <tglx@...utronix.de>, <will@...nel.org>, <joro@...tes.org>,
        <jassisinghbrar@...il.com>, <lee@...nel.org>,
        <linus.walleij@...aro.org>, <amitk@...nel.org>,
        <thara.gopinath@...il.com>, <broonie@...nel.org>,
        <wim@...ux-watchdog.org>, <linux@...ck-us.net>, <robin.murphy@....com>,
        <cristian.marussi@....com>, <rui.zhang@...el.com>,
        <lukasz.luba@....com>, <vkoul@...nel.org>, <quic_gurus@...cinc.com>,
        <agross@...nel.org>, <bartosz.golaszewski@...aro.org>,
        <quic_rjendra@...cinc.com>, <robimarko@...il.com>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-pm@...r.kernel.org>,
        <linux-crypto@...r.kernel.org>, <arm-scmi@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-i2c@...r.kernel.org>,
        <iommu@...ts.linux.dev>, <linux-gpio@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, <linux-spi@...r.kernel.org>,
        <linux-watchdog@...r.kernel.org>, <kernel@...cinc.com>,
        <quic_psodagud@...cinc.com>, <quic_tsoni@...cinc.com>,
        <quic_shazhuss@...cinc.com>
Subject: Re: [PATCH 11/22] pinctrl: qcom: sa8775p: Add support for SA8255p SoC


On 8/30/2024 2:52 AM, Krzysztof Kozlowski wrote:
> On 29/08/2024 16:17, Nikunj Kela wrote:
>> On 8/29/2024 12:29 AM, Krzysztof Kozlowski wrote:
>>> On Wed, Aug 28, 2024 at 01:37:10PM -0700, Nikunj Kela wrote:
>>>> SA8255p platform uses the same TLMM block as used in SA8775p,
>>>> though the pins are split between Firmware VM and Linux VM.
>>>> let's add SA8255p specific compatible.
>>> The change suggests devices are fully compatible, but above description
>>> does not.
>>>
>>> This looks conflicting.
>>>
>>> Best regards,
>>> Krzysztof
>> Hi Krzysztof,
>>
>> Thanks for reviewing patches. TLMM HW block is exactly same as used in
>> SA8775p however ownership of pins can be split between firmware VM and
>> Linux VM. It is upto devices to decide what pins they want to use in
>> what VM. I will extend the subject with same description as used in DT
>> binding.
> So there is no difference? Then devices should be made compatible with
> fallback.
>
> Best regards,
> Krzysztof

Yes, I get your point now. I will discuss internally. I am leaning
towards using sa8775p-tlmm compatible in SA8255p TLMM node so there is
no need for adding new compatible. Will drop the two pincontrol related
patches from the series in next version if agreed internally.

Thanks,

-Nikunj