linux-kernel - Re: [PATCH] mm/vma: Return the exact errno for vms_gather_munmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3zloqsccdzrelzht454tpafo3jseckjtnbyznyn7ve25m62uyf@olxy27mjxn42>
Date: Tue, 3 Sep 2024 11:58:26 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Xiao Yang <ice_yangxiao@....com>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, ltp@...ts.linux.it,
        andrea.cervesato@...e.com, oliver.sang@...el.com
Subject: Re: [PATCH] mm/vma: Return the exact errno for
 vms_gather_munmap_vmas()


Thanks, but this is already fixed in v8 of my patches.

* Xiao Yang <ice_yangxiao@....com> [240901 10:51]:
> can_modify_vma() in vms_gather_munmap_vmas() returns -EPERM if vma is
> sealed so don't always return the fixed -ENOMEM on failure.
> 
> Fixes: c2eb22189bbc ("mm/vma: inline munmap operation in mmap_region()")
> Fixes: 5887a7ac2383 ("mm/vma: expand mmap_region() munmap call")
> Signed-off-by: Xiao Yang <ice_yangxiao@....com>
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Closes: https://lore.kernel.org/oe-lkp/202408312155.fd26a58c-oliver.sang@intel.com
> ---
>  mm/mmap.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/mmap.c b/mm/mmap.c
> index c1781f643046..c9a0dc035819 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -1386,8 +1386,9 @@ unsigned long mmap_region(struct file *file, unsigned long addr,
>  		mt_on_stack(mt_detach);
>  		mas_init(&mas_detach, &mt_detach, /* addr = */ 0);
>  		/* Prepare to unmap any existing mapping in the area */
> -		if (vms_gather_munmap_vmas(&vms, &mas_detach))
> -			return -ENOMEM;
> +		error = vms_gather_munmap_vmas(&vms, &mas_detach);
> +		if (error)
> +			return error;
>  
>  		vmg.next = vms.next;
>  		vmg.prev = vms.prev;
> -- 
> 2.44.0
> 
>