linux-kernel - Re: [PATCH v2 0/2] netfilter: nf_tables: Fix percpu address space issues in nf_tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ztc16pw4r3Tf_U7h@calendula>
Date: Tue, 3 Sep 2024 18:14:34 +0200
From: Pablo Neira Ayuso <pablo@...filter.org>
To: Uros Bizjak <ubizjak@...il.com>
Cc: netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jozsef Kadlecsik <kadlec@...filter.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH v2 0/2] netfilter: nf_tables: Fix percpu address space
 issues in nf_tables_api.c

Hi,

On Thu, Aug 29, 2024 at 05:29:30PM +0200, Uros Bizjak wrote:
> Use {ERR_PTR,IS_ERR,PTR_ERR}_PCPU() macros when crossing between generic
> and percpu address spaces and add __percpu annotation to *stats pointer
> to fix percpu address space issues.

IIRC, you submitted patch 1/2 in this series to the mm tree.

Let us know if this patch gets upstreamed via MM tree (if mm
maintainers are fine with it) or maybe MM maintainers prefer an
alternative path for this.

Thanks.

> NOTE: The patch depends on a patch that introduces *_PCPU() macros [1]
> that is on the way to mainline through the mm tree. For convience, the
> patch is included in this patch series, so CI tester is able to test
> the second patch without compile failures.
> 
> [1] https://lore.kernel.org/lkml/20240818210235.33481-1-ubizjak@gmail.com/
> 
> The netfilter patch obsoletes patch [2].
> 
> [2] https://patchwork.ozlabs.org/project/netfilter-devel/patch/20240806102808.804619-1-ubizjak@gmail.com/
> 
> Cc: Pablo Neira Ayuso <pablo@...filter.org>
> Cc: Jozsef Kadlecsik <kadlec@...filter.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> 
> Uros Bizjak (2):
>   err.h: Add ERR_PTR_PCPU(), PTR_ERR_PCPU() and IS_ERR_PCPU() macros
>   netfilter: nf_tables: Fix percpu address space issues in
>     nf_tables_api.c
> 
>  include/linux/err.h           |  9 +++++++++
>  net/netfilter/nf_tables_api.c | 16 ++++++++--------
>  2 files changed, 17 insertions(+), 8 deletions(-)
> 
> -- 
> 2.42.0
>