linux-kernel - Re: [PATCH v4 3/9] dt-bindings: i2c: i2c-rk3x: Add rk3576 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ycbhqmkwz2hirnvp6j47kz3cxnli3db3i5ah76gngrezs5ww2r@57x2gxnr5hyk>
Date: Tue, 3 Sep 2024 18:47:17 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Detlev Casanova <detlev.casanova@...labora.com>
Cc: linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Heiko Stuebner <heiko@...ech.de>, David Airlie <airlied@...il.com>, 
	Daniel Vetter <daniel@...ll.ch>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>, 
	Mark Brown <broonie@...nel.org>, Wim Van Sebroeck <wim@...ux-watchdog.org>, 
	Guenter Roeck <linux@...ck-us.net>, Chris Morgan <macromorgan@...mail.com>, 
	Jonas Karlman <jonas@...boo.se>, Tim Lunn <tim@...thertop.org>, Andy Yan <andyshrk@....com>, 
	Muhammed Efe Cetin <efectn@...tonmail.com>, Jagan Teki <jagan@...eble.ai>, Dragan Simic <dsimic@...jaro.org>, 
	Ondrej Jirman <megi@....cz>, Michael Riesch <michael.riesch@...fvision.net>, 
	Jimmy Hon <honyuenkwun@...il.com>, Elon Zhang <zhangzj@...k-chips.com>, 
	Alexey Charkov <alchark@...il.com>, Elaine Zhang <zhangqing@...k-chips.com>, 
	Yifeng Zhao <yifeng.zhao@...k-chips.com>, Finley Xiao <finley.xiao@...k-chips.com>, 
	Liang Chen <cl@...k-chips.com>, Jamie Iles <jamie@...ieiles.com>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, 
	dri-devel@...ts.freedesktop.org, linux-i2c@...r.kernel.org, linux-serial@...r.kernel.org, 
	linux-spi@...r.kernel.org, linux-watchdog@...r.kernel.org, kernel@...labora.com, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v4 3/9] dt-bindings: i2c: i2c-rk3x: Add rk3576 compatible

Hi,

On Tue, Sep 03, 2024 at 11:59:34AM GMT, Detlev Casanova wrote:
> On Tuesday, 3 September 2024 11:46:00 EDT Andi Shyti wrote:
> > Hi,
> > 
> > On Tue, Sep 03, 2024 at 11:22:33AM GMT, Detlev Casanova wrote:
> > > Just like RK356x and RK3588, RK3576 is compatible to the existing
> > > rk3399 binding.
> > > 
> > > Signed-off-by: Detlev Casanova <detlev.casanova@...labora.com>
> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > > Acked-by: Heiko Stuebner <heiko@...ech.de>
> > 
> > I will apply this after 1 and 2 have been merged.
> 
> Sure, although it is not really dependent on 1 and 2.

yes, but I want to be sure that everything is coming in.

> > BTW, who is maintaining rockchip.yaml?
> 
> Heiko Stuebner is the maintainer of Rockchip SoC support.

I would guess so, but I think we should also add the entry to
the maintainer's file :-)

Thanks,
Andi

> > Thanks,
> > Andi
> > 
> > > ---
> > > 
> > >  Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml
> > > b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml index
> > > 82b9d6682297..a9dae5b52f28 100644
> > > --- a/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml
> > > +++ b/Documentation/devicetree/bindings/i2c/i2c-rk3x.yaml
> > > 
> > > @@ -38,6 +38,7 @@ properties:
> > >                - rockchip,rk3308-i2c
> > >                - rockchip,rk3328-i2c
> > >                - rockchip,rk3568-i2c
> > > 
> > > +              - rockchip,rk3576-i2c
> > > 
> > >                - rockchip,rk3588-i2c
> > >                - rockchip,rv1126-i2c
> > >            
> > >            - const: rockchip,rk3399-i2c
> 
> 
> 
>