lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8160bbe9-3b36-4232-8d34-4a5ecaa6815e@broadcom.com>
Date: Tue, 3 Sep 2024 10:45:28 -0700
From: florian.fainelli@...adcom.com
To: Bjorn Helgaas <helgaas@...nel.org>,
 Jim Quinlan <james.quinlan@...adcom.com>
Cc: Nicolas Saenz Julienne <nsaenz@...nel.org>,
 Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
 Cyril Brulebois <kibi@...ian.org>, Stanimir Varbanov <svarbanov@...e.de>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>,
 jim2101024@...il.com, bcm-kernel-feedback-list@...adcom.com,
 linux-pci@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] PCI: brcmstb: Sort enums, pcie_offsets[], pcie_cfg_data,
 .compatible strings

On 9/2/24 13:54, 'Bjorn Helgaas' via BCM-KERNEL-FEEDBACK-LIST,PDL wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> Sort enum pcie_soc_base values.
> 
> Rename pcie_offsets_bmips_7425[] to pcie_offsets_bcm7425[] to match BCM7425
> pcie_soc_base enum, bcm7425_cfg, and "brcm,bcm7425-pcie" .compatible
> string.
> 
> Rename pcie_offset_bcm7278[] to pcie_offsets_bcm7278[] to match other
> "pcie_offsets" names.
> 
> Rename pcie_offset_bcm7712[] to pcie_offsets_bcm7712[] to match other
> "pcie_offsets" names.
> 
> Sort pcie_offsets_*[] by SoC name, move them all together, indent values
> for easy reading.
> 
> Sort pcie_cfg_data structs by SoC name.
> 
> Sort .compatible strings by SoC name.
> 
> No functional change intended.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>

There was some appeal in preserving the enumeration in the order in 
which the chips have been produced, like 7425, 7435 etc.. but I see we 
probably got some parts of the timeline wrong at some point anyway.

Should we push a bit further an accept a little bit of duplication and 
simply embed the array of register offsets directly into the 
pcie_cfg_data structure, rather than a pointer to to an array?
-- 
Florian

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ