linux-kernel - Re: [PATCH] longsoon/percpu: Simplify _percpu_read() and _percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFULd4b_vemxT_6dWRWmjwZKyVSKyojY0Sw77hppsC+--qbZZQ@mail.gmail.com>
Date: Tue, 3 Sep 2024 21:01:12 +0200
From: Uros Bizjak <ubizjak@...il.com>
To: Xi Ruoyao <xry111@...111.site>
Cc: loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	Huacai Chen <chenhuacai@...nel.org>, WANG Xuerui <kernel@...0n.name>, 
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] longsoon/percpu: Simplify _percpu_read() and _percpu_write()

On Tue, Sep 3, 2024 at 8:57 PM Xi Ruoyao <xry111@...111.site> wrote:
>
> On Tue, 2024-09-03 at 12:23 +0200, Uros Bizjak wrote:
> > +#define _percpu_write(size, _pcp, _val)                                      \
> > +do {                                                                 \
> > +     unsigned long __pcp_val = __pcpu_cast_##size(_val);             \
> > +                                                                     \
> > +     __asm__ __volatile__ (__pcpu_op_##size("stx") "%[val] $r21, %[ptr]      \n" \
>
> Missing a comma before $r21 (as the bot already pointed out).

Oh, indeed... I triple checked the patch and missed the most obvious thing :(

BR,
Uros.

>
> > +             :                                                       \
> > +             : [val] "r"(__pcp_val), [ptr] "r"(&(_pcp))              \
> > +             : "memory");                                            \
> > +} while (0)
>
> --
> Xi Ruoyao <xry111@...111.site>
> School of Aerospace Science and Technology, Xidian University