linux-kernel - Re: [PATCH] mailbox: Use of_property_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqLzpDC42G35TDjgQpDCJhmy6_oQxG97uut9VKdYCHi_NQ@mail.gmail.com>
Date: Tue, 3 Sep 2024 14:17:58 -0500
From: Rob Herring <robh@...nel.org>
To: Jassi Brar <jassisinghbrar@...il.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mailbox: Use of_property_match_string() instead of open-coding

On Wed, Jul 31, 2024 at 3:16 PM Rob Herring (Arm) <robh@...nel.org> wrote:
>
> Use of_property_match_string() instead of open-coding the search. With
> this, of_get_property() can be removed as there is no need to check for
> "mbox-names" presence first.
>
> This is part of a larger effort to remove callers of of_get_property()
> and similar functions. of_get_property() leaks the DT property data
> pointer which is a problem for dynamically allocated nodes which may
> be freed.
>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>  drivers/mailbox/mailbox.c | 22 ++++++----------------
>  1 file changed, 6 insertions(+), 16 deletions(-)

Ping!

>
> diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c
> index ebff3baf3045..d3d26a2c9895 100644
> --- a/drivers/mailbox/mailbox.c
> +++ b/drivers/mailbox/mailbox.c
> @@ -450,30 +450,20 @@ struct mbox_chan *mbox_request_channel_byname(struct mbox_client *cl,
>                                               const char *name)
>  {
>         struct device_node *np = cl->dev->of_node;
> -       struct property *prop;
> -       const char *mbox_name;
> -       int index = 0;
> +       int index;
>
>         if (!np) {
>                 dev_err(cl->dev, "%s() currently only supports DT\n", __func__);
>                 return ERR_PTR(-EINVAL);
>         }
>
> -       if (!of_get_property(np, "mbox-names", NULL)) {
> -               dev_err(cl->dev,
> -                       "%s() requires an \"mbox-names\" property\n", __func__);
> +       index = of_property_match_string(np, "mbox-names", name);
> +       if (index < 0) {
> +               dev_err(cl->dev, "%s() could not locate channel named \"%s\"\n",
> +                       __func__, name);
>                 return ERR_PTR(-EINVAL);
>         }
> -
> -       of_property_for_each_string(np, "mbox-names", prop, mbox_name) {
> -               if (!strncmp(name, mbox_name, strlen(name)))
> -                       return mbox_request_channel(cl, index);
> -               index++;
> -       }
> -
> -       dev_err(cl->dev, "%s() could not locate channel named \"%s\"\n",
> -               __func__, name);
> -       return ERR_PTR(-EINVAL);
> +       return mbox_request_channel(cl, index);
>  }
>  EXPORT_SYMBOL_GPL(mbox_request_channel_byname);
>
> --
> 2.43.0
>