linux-kernel - Re: [PATCH] drm: vc4: Use of_property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqKvA0Uw7uqpmdMP7Z4mL3Qsmay5Fqb4M97s=QsBW_Nxyg@mail.gmail.com>
Date: Tue, 3 Sep 2024 14:19:38 -0500
From: Rob Herring <robh@...nel.org>
To: Maxime Ripard <mripard@...nel.org>, Dave Stevenson <dave.stevenson@...pberrypi.com>, 
	Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Thomas Zimmermann <tzimmermann@...e.de>, 
	David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: vc4: Use of_property_present()

On Wed, Jul 31, 2024 at 2:13 PM Rob Herring (Arm) <robh@...nel.org> wrote:
>
> Use of_property_present() to test for property presence rather than
> of_find_property(). This is part of a larger effort to remove callers
> of of_find_property() and similar functions. of_find_property() leaks
> the DT struct property and data pointers which is a problem for
> dynamically allocated nodes which may be freed.
>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>  drivers/gpu/drm/vc4/vc4_hdmi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Ping!

>
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index d57c4a5948c8..049de06460d5 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -2211,7 +2211,7 @@ static int vc4_hdmi_audio_init(struct vc4_hdmi *vc4_hdmi)
>         struct device *dev = &vc4_hdmi->pdev->dev;
>         struct platform_device *codec_pdev;
>         const __be32 *addr;
> -       int index, len;
> +       int index;
>         int ret;
>
>         /*
> @@ -2234,7 +2234,7 @@ static int vc4_hdmi_audio_init(struct vc4_hdmi *vc4_hdmi)
>         BUILD_BUG_ON(offsetof(struct vc4_hdmi_audio, card) != 0);
>         BUILD_BUG_ON(offsetof(struct vc4_hdmi, audio) != 0);
>
> -       if (!of_find_property(dev->of_node, "dmas", &len) || !len) {
> +       if (!of_property_present(dev->of_node, "dmas")) {
>                 dev_warn(dev,
>                          "'dmas' DT property is missing or empty, no HDMI audio\n");
>                 return 0;
> --
> 2.43.0
>