linux-kernel - Re: [PATCH v8 04/11] PCI: imx6: Rename imx6_* with imx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtdofnRRoa2WZ1Vf@lizhi-Precision-Tower-5810>
Date: Tue, 3 Sep 2024 15:50:22 -0400
From: Frank Li <Frank.li@....com>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Richard Zhu <hongxing.zhu@....com>,
	Lucas Stach <l.stach@...gutronix.de>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kw@...ux.com>,
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	NXP Linux Team <linux-imx@....com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-pci@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v8 04/11] PCI: imx6: Rename imx6_* with imx_*

On Tue, Sep 03, 2024 at 02:37:39PM -0500, Bjorn Helgaas wrote:
> On Mon, Jul 29, 2024 at 04:18:11PM -0400, Frank Li wrote:
> > Since this driver has evolved to support other i.MX SoCs such as i.MX7/8/9,
> > let's rename the 'imx6' prefix to 'imx' to avoid confusion. But the driver
> > name is left unchanged to avoid breaking userspace scripts
>
> s/let's//
>
> It's not a proposal, it's what the patch *does*.
>
> s/But the driver name is left unchanged/Leave the driver name unchanged/
>
> s/scripts/scripts./ (add period)

Good capture, sorry for this error.

>
> > -#define IMX6_PCIE_FLAG_IMX6_PHY			BIT(0)
> > -#define IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE	BIT(1)
> > -#define IMX6_PCIE_FLAG_SUPPORTS_SUSPEND		BIT(2)
> > -#define IMX6_PCIE_FLAG_HAS_PHYDRV			BIT(3)
> > -#define IMX6_PCIE_FLAG_HAS_APP_RESET		BIT(4)
> > -#define IMX6_PCIE_FLAG_HAS_PHY_RESET		BIT(5)
> > -#define IMX6_PCIE_FLAG_HAS_SERDES		BIT(6)
> > -#define IMX6_PCIE_FLAG_SUPPORT_64BIT		BIT(7)
> > +#define IMX_PCIE_FLAG_IMX_PHY			BIT(0)
> > +#define IMX_PCIE_FLAG_IMX_SPEED_CHANGE	BIT(1)
> > +#define IMX_PCIE_FLAG_SUPPORTS_SUSPEND		BIT(2)
> > +#define IMX_PCIE_FLAG_HAS_PHYDRV			BIT(3)
>
> Good opportunity to fix the whitespace errors while renaming these.
> IMX_PCIE_FLAG_IMX_SPEED_CHANGE and IMX_PCIE_FLAG_HAS_PHYDRV end up
> with the wrong indentation.
>
> > -#define imx6_check_flag(pci, val)     (pci->drvdata->flags & val)
> > +#define imx_check_flag(pci, val)     (pci->drvdata->flags & val)
> >
> > -#define IMX6_PCIE_MAX_CLKS       6
> > +#define IMX_PCIE_MAX_CLKS       6
>
> Could also make these look nicer.
>
> We can touch these up, no need to repost.

Thanks.

Frank