linux-kernel - Re: [PATCH] dt: dt-extract-compatibles: Extract compatibles from function parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGETcx-rHM6Hmu6bTBzsud=BaKTZgZsw2=R=fsZsLkMOzesGZQ@mail.gmail.com>
Date: Tue, 3 Sep 2024 13:34:45 -0700
From: Saravana Kannan <saravanak@...gle.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Nícolas F . R . A . Prado <nfraprado@...labora.com>, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt: dt-extract-compatibles: Extract compatibles from
 function parameters

On Tue, Sep 3, 2024 at 1:07 PM Rob Herring (Arm) <robh@...nel.org> wrote:
>
> Various DT and fwnode functions take a compatible string as a parameter.
> These are often used in cases which don't have a driver, so they've been
> missed.
>
> The additional checks add about 400 more undocumented compatible
> strings.
>
> Cc: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>

Acked-by: Saravana Kannan <saravanak@...gle.com>

-Saravana

> ---
>  scripts/dtc/dt-extract-compatibles | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/scripts/dtc/dt-extract-compatibles b/scripts/dtc/dt-extract-compatibles
> index 5ffb2364409b..13ea66d49e6c 100755
> --- a/scripts/dtc/dt-extract-compatibles
> +++ b/scripts/dtc/dt-extract-compatibles
> @@ -46,6 +46,15 @@ def parse_of_match_table(data):
>         return match_table_list
>
>
> +def parse_of_functions(data, func_name):
> +       """ Find all (device|machine)_is_compatible() arguments """
> +       match_table_list = []
> +       for m in re.finditer(rf'{func_name}\(([a-zA-Z0-9_>\(\)"\-]+,\s)*"([a-zA-Z0-9_,-]+)"\)', data):
> +               match_table_list.append(m[2])
> +
> +       return match_table_list
> +
> +
>  def parse_compatibles(file, compat_ignore_list):
>         with open(file, 'r', encoding='utf-8') as f:
>                 data = f.read().replace('\n', '')
> @@ -60,6 +69,10 @@ def parse_compatibles(file, compat_ignore_list):
>         else:
>                 compat_list = parse_of_declare_macros(data)
>                 compat_list += parse_of_device_id(data)
> +               compat_list += parse_of_functions(data, "_is_compatible")
> +               compat_list += parse_of_functions(data, "of_find_compatible_node")
> +               compat_list += parse_of_functions(data, "for_each_compatible_node")
> +               compat_list += parse_of_functions(data, "of_get_compatible_child")
>
>         return compat_list
>
> --
> 2.45.2
>