linux-kernel - Re: [PATCH v2 1/2] x86, KVM:SVM: Move sev specific parsing into arch/x86/virt/svm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ab9f0c78-0e7e-95b4-5b24-5264d745e44f@amd.com>
Date: Tue, 3 Sep 2024 15:38:06 -0500
From: "Paluri, PavanKumar" <papaluri@....com>
To: linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-doc@...r.kernel.org,
 Borislav Petkov <bp@...en8.de>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Dave Hansen <dave.hansen@...ux.intel.com>,
 Eric Van Tassell <Eric.VanTassell@....com>,
 Tom Lendacky <thomas.lendacky@....com>, Ashish Kalra <ashish.kalra@....com>,
 Michael Roth <michael.roth@....com>, "H . Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH v2 1/2] x86, KVM:SVM: Move sev specific parsing into
 arch/x86/virt/svm



On 9/3/2024 3:44 AM, kernel test robot wrote:
> Hi Pavan,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on a85536e1bce722cb184abbac98068217874bdd6e]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Pavan-Kumar-Paluri/x86-KVM-SVM-Move-sev-specific-parsing-into-arch-x86-virt-svm/20240903-083803
> base:   a85536e1bce722cb184abbac98068217874bdd6e
> patch link:    https://lore.kernel.org/r/20240903003511.1530454-2-papaluri%40amd.com
> patch subject: [PATCH v2 1/2] x86, KVM:SVM: Move sev specific parsing into arch/x86/virt/svm
> config: i386-buildonly-randconfig-001-20240903 (https://download.01.org/0day-ci/archive/20240903/202409031656.SS8NsjIN-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240903/202409031656.SS8NsjIN-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202409031656.SS8NsjIN-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from arch/x86/include/asm/sev.h:16,
>                     from arch/x86/virt/svm/cmdline.c:13:
>>> arch/x86/include/asm/coco.h:28:18: warning: 'cc_mask' defined but not used [-Wunused-const-variable=]
>       28 | static const u64 cc_mask = 0;
>          |                  ^~~~~~~
> 
> 
> vim +/cc_mask +28 arch/x86/include/asm/coco.h
> 
> 1c811d403afd73 Ard Biesheuvel     2024-02-03  22  
> b577f542f93cbb Kirill A. Shutemov 2022-02-22  23  u64 cc_mkenc(u64 val);
> b577f542f93cbb Kirill A. Shutemov 2022-02-22  24  u64 cc_mkdec(u64 val);
> 99485c4c026f02 Jason A. Donenfeld 2024-03-26  25  void cc_random_init(void);
> b577f542f93cbb Kirill A. Shutemov 2022-02-22  26  #else
> e4596477100706 Nathan Chancellor  2024-02-02  27  #define cc_vendor (CC_VENDOR_NONE)
> a0a8d15a798be4 Kirill A. Shutemov 2024-04-24 @28  static const u64 cc_mask = 0;
> e4596477100706 Nathan Chancellor  2024-02-02  29  
> 

The following diff resolves the build warning reported by kernel test robot.

diff --git a/arch/x86/virt/svm/cmdline.c b/arch/x86/virt/svm/cmdline.c
index 43039ec67606..9b900e950b4b 100644
--- a/arch/x86/virt/svm/cmdline.c
+++ b/arch/x86/virt/svm/cmdline.c
@@ -11,7 +11,7 @@
 #include <linux/printk.h>

 #include <asm/cpufeature.h>
-#include <asm/sev.h>
+#include <asm/sev-common.h>

 struct sev_config sev_cfg;

I will apply this fix to the patch and send a v3.

Thanks,
Pavan