linux-kernel - Re: [PATCH] mm: Kconfig: fixup zsmalloc configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240903142847.f03362654cac51bf4617fe18@linux-foundation.org>
Date: Tue, 3 Sep 2024 14:28:47 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Johannes Weiner <hannes@...xchg.org>
Cc: Sergey Senozhatsky <senozhatsky@...omium.org>, Minchan Kim
 <minchan@...nel.org>, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: Kconfig: fixup zsmalloc configuration

On Tue, 3 Sep 2024 13:55:28 -0400 Johannes Weiner <hannes@...xchg.org> wrote:

> On Tue, Sep 03, 2024 at 01:00:22PM +0900, Sergey Senozhatsky wrote:
> > zsmalloc is not exclusive to zswap. Commit aa3ba6d72ce0
> > ("mm: Kconfig: fixup zsmalloc configuration") made CONFIG_ZSMALLOC
> > only visible when CONFIG_ZSWAP is selected, which makes it
> > impossible to menuconfig zsmalloc-specific features (stats,
> > chain-size, etc.) on systems that use ZRAM but don't have ZSWAP
> > enabled.
> > 
> > Make zsmalloc depend on both ZRAM and ZSWAP.
> > 
> > Fixes: Fixes: aa3ba6d72ce0 ("mm: Kconfig: fixup zsmalloc configuration")
> 
> I can't find this commit upstream.
> 
> It looks like this was actually broken by
> 
> commit b3fbd58fcbb10725a1314688e03b1af6827c42f9
> Author: Johannes Weiner <hannes@...xchg.org>
> Date:   Thu May 19 14:08:53 2022 -0700
> 
>     mm: Kconfig: simplify zswap configuration
> 
> instead?

Agree, I edited that into the changelog.