linux-kernel - Re: [RESEND PATCH] PCI: hotplug: check the return of hotplug bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240903223918.GA307750@bhelgaas>
Date: Tue, 3 Sep 2024 17:39:18 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Guilherme Giacomo Simoes <trintaeoitogc@...il.com>
Cc: scott@...teful.org, bhelgaas@...gle.com, ilpo.jarvinen@...ux.intel.com,
	wsa+renesas@...g-engineering.com, lukas@...ner.de,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] PCI: hotplug: check the return of hotplug bridge

On Sat, Aug 31, 2024 at 10:28:21AM -0300, Guilherme Giacomo Simoes wrote:
> In some pci drivers, when the pci bridge is added if the process return an error,
> the drivers don't check this and continue your execute normally.
> Then, this patch change this drivers for check return of pci_hp_add_bridge(), and
> if has an error, then the drivers call goto lable , free your mutex and return the
> error for your caller.
> 
> Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@...il.com>

Did you see Lukas' response at
https://lore.kernel.org/r/ZsAzM8K9PnN5jxR9@wunner.de ?

AFAICT the discussion he pointed to is very relevant and needs to be
considered before we apply a patch like this.

If you have addressed those comments, please describe how you
addressed them in the commit log, and include links to Nam Cao's work
and cc them as well.

Bjorn