linux-kernel - Re: [PATCH v2] net: alacritech: Partially revert "net: alacritech: Switch to use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <172540323175.471018.14716826059203636030.git-patchwork-notify@kernel.org>
Date: Tue, 03 Sep 2024 22:40:31 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: LinoSanfilippo@....de, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, 11162571@...o.com,
 jacob.e.keller@...el.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: alacritech: Partially revert "net: alacritech: Switch
 to use dev_err_probe()"

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Mon,  2 Sep 2024 18:36:10 +0200 you wrote:
> This reverts commit bf4d87f884fe8a4b6b61fe4d0e05f293d08df61c because it
> introduced dev_err_probe() in non-probe path, which is not desired.
> 
> In general, calling dev_err_probe() after successful probe in case of
> handling -EPROBE_DEFER error, will set deferred status on the device
> already probed.  This is however not a problem here now, because
> dev_err_probe() in affected places is used for handling errors from
> request_firmware(), which does not return -EPROBE_DEFER.  Still usage of
> dev_err_probe() in such case is not correct, because request_firmware()
> could once return -EPROBE_DEFER.
> 
> [...]

Here is the summary with links:
  - [v2] net: alacritech: Partially revert "net: alacritech: Switch to use dev_err_probe()"
    https://git.kernel.org/netdev/net-next/c/9748229c90dc

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html