linux-kernel - Re: [PATCH v2] dpaa2-switch: fix flooding domain among multiple vlans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240902183723.0dd4d192@kernel.org>
Date: Mon, 2 Sep 2024 18:37:23 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Wan Junjie <junjie.wan@...eptio.ai>
Cc: horms@...nel.org, davem@...emloft.net, edumazet@...gle.com,
 ioana.ciornei@....com, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, pabeni@...hat.com
Subject: Re: [PATCH v2] dpaa2-switch: fix flooding domain among multiple
 vlans

On Mon,  2 Sep 2024 20:43:18 +0800 Wan Junjie wrote:
> > > -static u16 dpaa2_switch_port_get_fdb_id(struct ethsw_port_priv *port_priv)
> > > +static u16 dpaa2_switch_port_get_fdb_id(struct ethsw_port_priv *port_priv, u16 vid)  
> > 
> > This, and several other lines in this patch, could be trivially
> > line wrapped in order for them to be <= 80 columns wide, as is
> > still preferred in Networking code.
> > 
> > This and a number of other minor problems are flagged by:
> > ./scripts/checkpatch.pl --strict --codespell --max-line-length=80  
> 
> It is hard to keep all lines limited to the length of 80 since some function
> names are really long. I have tried to make the line length to 85 without
> breaking some if conditions into multiple lines. You will see in v3.

FWIW it's relatively common to break the line after return type:

static u16
dpaa2_switch_port_get_fdb_id(struct ethsw_port_priv *port_priv, u16 vid)