[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ac1b3ba2-ac57-411c-acdb-69d288d88355@quicinc.com>
Date: Tue, 3 Sep 2024 15:30:06 +0800
From: Jingyi Wang <quic_jingyw@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio
<konradybcio@...nel.org>,
Conor Dooley <conor@...nel.org>, Rob Herring
<robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
<linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] dt-bindings: cache: qcom,llcc: add num-banks property
On 9/3/2024 3:10 PM, Krzysztof Kozlowski wrote:
> On Tue, Sep 03, 2024 at 02:21:29PM +0800, Jingyi Wang wrote:
>> Add a property "num-banks" for errata.
>
> This you said in commit subject and we see in the diff. You *MUST*
> explain why.
>
>>
>> Signed-off-by: Jingyi Wang <quic_jingyw@...cinc.com>
>> ---
>> Documentation/devicetree/bindings/cache/qcom,llcc.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
>> index 68ea5f70b75f..03241b719c98 100644
>> --- a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
>> +++ b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
>> @@ -56,6 +56,11 @@ properties:
>> items:
>> - const: multi-chan-ddr
>>
>> + num-banks:
>
> No vendor prefix? So this is generic property? Then add to some common
> schema with proper explanation WHY.
>
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description:
>> + The num of llcc banks
>
> And what are llcc (or LLCC?) banks?
>
>
Will add the vendor prefix and description in the next series.
> Best regards,
> Krzysztof
>
Thanks,
Jingyi
Powered by blists - more mailing lists