linux-kernel - Re: [PATCH RESEND] wifi: mt76: mt7921: Check devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wmjtjhup.fsf@kernel.org>
Date: Tue, 03 Sep 2024 10:50:54 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Ma Ke <make24@...as.ac.cn>
Cc: nbd@....name,  lorenzo@...nel.org,  ryder.lee@...iatek.com,
  shayne.chen@...iatek.com,  sean.wang@...iatek.com,
  matthias.bgg@...il.com,  angelogioacchino.delregno@...labora.com,
  mingyen.hsieh@...iatek.com,  deren.wu@...iatek.com,
  ruanjinjie@...wei.com,  greearb@...delatech.com,
  akpm@...ux-foundation.org,  linux-wireless@...r.kernel.org,
  linux-kernel@...r.kernel.org,  linux-arm-kernel@...ts.infradead.org,
  linux-mediatek@...ts.infradead.org,  stable@...r.kernel.org
Subject: Re: [PATCH RESEND] wifi: mt76: mt7921: Check devm_kasprintf()
 returned value

Ma Ke <make24@...as.ac.cn> writes:

> devm_kasprintf() can return a NULL pointer on failure but this returned
> value is not checked. Fix this lack and check the returned value.
>
> Found by code review.
>
> Cc: stable@...r.kernel.org
> Fixes: 6ae39b7c7ed4 ("wifi: mt76: mt7921: Support temp sensor")
> Signed-off-by: Ma Ke <make24@...as.ac.cn>
> ---
>  drivers/net/wireless/mediatek/mt76/mt7921/init.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/init.c b/drivers/net/wireless/mediatek/mt76/mt7921/init.c
> index ef0c721d26e3..5ab395d9d93e 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/init.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/init.c
> @@ -52,6 +52,8 @@ static int mt7921_thermal_init(struct mt792x_phy *phy)
>  
>  	name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7921_%s",
>  			      wiphy_name(wiphy));
> +	if (!name)
> +		return -ENOMEM;
>  
>  	hwmon = devm_hwmon_device_register_with_groups(&wiphy->dev, name, phy,
>  						       mt7921_hwmon_groups);

You sent the previous version of this on August 26th:

https://patchwork.kernel.org/project/linux-wireless/patch/20240826095535.2603538-1-make24@iscas.ac.cn/

Please stop spamming like this and understand that maintainers are busy.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
https://docs.kernel.org/process/submitting-patches.html