linux-kernel - RE: [PATCH v2] usb: xhci: fixes lost of data for xHCI Cadence Controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PH7PR07MB95381C966C8994CE09696E67DD932@PH7PR07MB9538.namprd07.prod.outlook.com>
Date: Tue, 3 Sep 2024 08:23:38 +0000
From: Pawel Laszczak <pawell@...ence.com>
To: Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Michał Pecio <michal.pecio@...il.com>,
        "peter.chen@...nel.org" <peter.chen@...nel.org>
CC: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "mathias.nyman@...el.com" <mathias.nyman@...el.com>,
        "stable@...r.kernel.org"
	<stable@...r.kernel.org>
Subject: RE: [PATCH v2] usb: xhci: fixes lost of data for xHCI Cadence
 Controllers

Hi,

>On 30.8.2024 18.45, Michał Pecio wrote:
>> Hi,
>>
>>> Field Rsvd0 is reserved field, so patch should not have impact for
>>> other xHCI controllers.
>> Wait, is this a case of Linux failing to zero-initialize something
>> that should be zero initialized before use (why not explain it as
>> such?), or are you suggesting monkeying with internal xHC data at run
>> time, in area which is known to actually be used by at least one
>implementation?
>>
>
>Patch is monkeying with internal xHC RsvdO field.
>
>
>> There is no mention of Rsvd0 in the xHCI spec, did you mean RsvdO?
>>
>> Reserved and Opaque,
>> For exclusive use by the xHC.
>> Software shall *not* write this, unless allowed by the vendor.
>>
>> Cadence isn't the only xHC vendor...
>>
>
>Makes sense,  Pawel Laszczak, could you make this patch Cadence specific.

I understand your concerns. I will prepare new patch. 
For this purpose I'm going to add some extra quirk definition.

Thanks
Pawel

>
>Thanks
>Mathias