linux-kernel - Re: [PATCH 6/6] power: supply: Change usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f4e23ce-2f32-44fc-93d9-ab7d0867b0ee@redhat.com>
Date: Tue, 3 Sep 2024 10:27:08 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Sebastian Reichel <sre@...nel.org>,
 Thomas Weißschuh <linux@...ssschuh.net>,
 MyungJoo Ham <myungjoo.ham@...sung.com>, Chanwoo Choi
 <cw00.choi@...sung.com>, Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
 Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I <kishon@...nel.org>,
 Enric Balletbo Serra <enric.balletbo@...labora.com>,
 Andrey Smirnov <andrew.smirnov@...il.com>, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
 linux-phy@...ts.infradead.org
Subject: Re: [PATCH 6/6] power: supply: Change usb_types from an array into a
 bitmask

Hi Greg,

Thank you for the reviews.

On 9/3/24 9:04 AM, Greg Kroah-Hartman wrote:
> On Sat, Aug 31, 2024 at 04:20:39PM +0200, Hans de Goede wrote:
>> The bit_types array just hold a list of valid enum power_supply_usb_type
>> values which map to 0 - 9. This can easily be represented as a bitmap.
>>
>> This reduces the size of struct power_supply_desc and further reduces
>> the data section size by drivers no longer needing to store the array.
>>
>> This also unifies how usb_types are handled with charge_behaviours,
>> which allows power_supply_show_usb_type() to be removed.
>>
>> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> 
> Nice!
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

I assume this also counts as an ack for merging this through
the linux-power-supply tree ?

Regards,

Hans