linux-kernel - Re: [PATCH] HID: amd_sfh: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b87ecff-4ef9-4749-b85a-43e343d08c9a@amd.com>
Date: Tue, 3 Sep 2024 15:11:15 +0530
From: Basavaraj Natikar <bnatikar@....com>
To: Chen Ni <nichen@...as.ac.cn>, basavaraj.natikar@....com,
 jikos@...nel.org, bentiss@...nel.org, Shyam-sundar.S-k@....com,
 mario.limonciello@....com
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: amd_sfh: Convert comma to semicolon


On 9/3/2024 8:14 AM, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
> index 621793d92464..db36d87d5634 100644
> --- a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
> +++ b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
> @@ -299,8 +299,8 @@ static void amd_sfh_set_ops(struct amd_mp2_dev *mp2)
>  
>  	sfh_interface_init(mp2);
>  	mp2_ops = mp2->mp2_ops;
> -	mp2_ops->clear_intr = amd_sfh_clear_intr_v2,
> -	mp2_ops->init_intr = amd_sfh_irq_init_v2,
> +	mp2_ops->clear_intr = amd_sfh_clear_intr_v2;
> +	mp2_ops->init_intr = amd_sfh_irq_init_v2;
>  	mp2_ops->suspend = amd_sfh_suspend;
>  	mp2_ops->resume = amd_sfh_resume;
>  	mp2_ops->remove = amd_mp2_pci_remove;

Looks good to me.

Acked-by: Basavaraj Natikar <Basavaraj.Natikar@....com>

Thanks,
--
Basavaraj