linux-kernel - Re: [PATCH 2/2] driver core: class: warn if a compatibility class is registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024090338-landfall-geek-58df@gregkh>
Date: Tue, 3 Sep 2024 12:06:11 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Wolfram Sang <wsa@...nel.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] driver core: class: warn if a compatibility class is
 registered

On Tue, Sep 03, 2024 at 11:06:44AM +0200, Wolfram Sang wrote:
> On Tue, Sep 03, 2024 at 11:04:44AM +0200, Wolfram Sang wrote:
> > 
> > > > +	pr_warn("Compatibility class %s will go away soon, please migrate userspace tools to use bus devices\n",
> > > > +		name);
> > > 
> > > That's not going to do anything except annoy users who have no control
> > > over this, sorry.  Please just fix up all of the kernel and then delete
> > > this function.
> > 
> > So, we deprecated this sysfs-class 15 years ago and hid it with a
> > Kconfig symbol. However, we never pursued this further, so e.g. Debian
> > has the Kconfig symbol still enabled. Can we really remove this from one
> > release to the next without another transition period? I am not afraid
> > of tools like lm-sensors which were converted long ago. But custom code
> > might rely on sysfs-paths created by this class. It was even advertised
> > in IPMI docs until last week (fixed now).
> 
> I missed that Heiner was changing the driver core, not I2C core. So, to
> give more details, I am talking about I2C_COMPAT and the "i2c-adapter"
> class. The main question from above still stands.

Delete the code and see if anyone notices?  :)

greg k-h