linux-kernel - Re: [PATCH] docs: rust: fix formatting for kernel::block::mq::Request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72naAHm81thntNdaEoq8rMVH0gVNAKB_Fd5dy2Eu1pk5mA@mail.gmail.com>
Date: Tue, 3 Sep 2024 12:38:46 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Francesco Zardi <frazar00@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Wedson Almeida Filho <wedsonaf@...il.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...sung.com>, 
	Alice Ryhl <aliceryhl@...gle.com>, Jens Axboe <axboe@...nel.dk>, rust-for-linux@...r.kernel.org, 
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] docs: rust: fix formatting for kernel::block::mq::Request

On Mon, Sep 2, 2024 at 11:16 PM Francesco Zardi <frazar00@...il.com> wrote:
>
> Fix several issues with rustdoc formatting for the
> `kernel::block::mq::Request` module, in particular:

Thanks for the patch, Francesco! These look good (I didn't render it though).

> Closes: https://github.com/Rust-for-Linux/linux/issues/1108
>
> Signed-off-by: Francesco Zardi <frazar00@...il.com>
> Suggested-by: Miguel Ojeda <ojeda@...nel.org>

If we considered these a fix (I think at least for the first bullet
point it makes sense to do so), these should probably be (in this
order, and without blank newlines):

    Reported-by:
    Closes:
    Signed-off-by:

But depending on the maintainer they may do this without a v2 when
picking it up -- it depends on what Andreas wants to do (it could go
through Block or Rust).

Thanks!

Cheers,
Miguel