linux-kernel - Re: [PATCH 4/9] nvmem: layouts: add U-Boot env layout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024090308-smasher-craftwork-0db5@gregkh>
Date: Tue, 3 Sep 2024 12:12:56 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: srinivas.kandagatla@...aro.org
Cc: linux-kernel@...r.kernel.org,
	Rafał Miłecki <rafal@...ecki.pl>,
	Miquel Raynal <miquel.raynal@...tlin.com>
Subject: Re: [PATCH 4/9] nvmem: layouts: add U-Boot env layout

On Mon, Sep 02, 2024 at 03:29:47PM +0100, srinivas.kandagatla@...aro.org wrote:
> From: Rafał Miłecki <rafal@...ecki.pl>
> 
> U-Boot environment variables are stored in a specific format. Actual
> data can be placed in various storage sources (MTD, UBI volume, EEPROM,
> NVRAM, etc.).
> 
> Move all generic (NVMEM device independent) code from NVMEM device
> driver to an NVMEM layout driver. Then add a simple NVMEM layout code on
> top of it.
> 
> This allows using NVMEM layout for parsing U-Boot env data stored in any
> kind of NVMEM device.
> 
> The old NVMEM glue driver stays in place for handling bindings in the
> MTD context. To avoid code duplication it uses exported layout parsing
> function. Please note that handling MTD & NVMEM layout bindings may be
> refactored in the future.
> 
> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
> Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
>  MAINTAINERS                        |   1 +
>  drivers/nvmem/Kconfig              |   3 +-
>  drivers/nvmem/layouts/Kconfig      |  11 ++
>  drivers/nvmem/layouts/Makefile     |   1 +
>  drivers/nvmem/layouts/u-boot-env.c | 211 +++++++++++++++++++++++++++++
>  drivers/nvmem/layouts/u-boot-env.h |  15 ++
>  drivers/nvmem/u-boot-env.c         | 165 +---------------------
>  7 files changed, 242 insertions(+), 165 deletions(-)
>  create mode 100644 drivers/nvmem/layouts/u-boot-env.c
>  create mode 100644 drivers/nvmem/layouts/u-boot-env.h

This patch doesn't apply to my tree :(

Also, if you generate patches with 'git format-patch -M' you can see
when files move easier (if that's what happened here, hard to tell..)

thanks,

greg k-h