linux-kernel - Re: [PATCH v1 1/1] pinctrl: intel: Constify struct intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcF=bnD94xFDC06knZBU=NyArwj5Yh2qaa=T5mGyuPK1g@mail.gmail.com>
Date: Tue, 3 Sep 2024 14:04:23 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Andy Shevchenko <andy@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/1] pinctrl: intel: Constify struct intel_pinctrl parameter

On Tue, Sep 3, 2024 at 7:57 AM Mika Westerberg
<mika.westerberg@...ux.intel.com> wrote:
> On Mon, Sep 02, 2024 at 05:15:11PM +0300, Andy Shevchenko wrote:
> > -static void __iomem *intel_get_padcfg(struct intel_pinctrl *pctrl,
> > +static void __iomem *intel_get_padcfg(const struct intel_pinctrl *pctrl,
> >                                     unsigned int pin, unsigned int reg)
>
> This is not good. You take const pointer but return non-const inside
> that struct. I don't think we should "change" the constness this way.

I see. I will double check this. Thank you for reviewing this!

> All changes that take const pointer and return scalar are fine, though
> (did not check all of them).



-- 
With Best Regards,
Andy Shevchenko