linux-kernel - Re: [PATCH v2 2/2] Loongarch: EDAC driver for loongson memory controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d6674376-f404-4b65-899f-4c7cfcf9524b@kernel.org>
Date: Tue, 3 Sep 2024 13:36:56 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Zhao Qunqin <zhaoqunqin@...ngson.cn>, Xi Ruoyao <xry111@...111.site>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 chenhuacai@...nel.org, linux-edac@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, kernel@...0n.name,
 bp@...en8.de, tony.luck@...el.com, james.morse@....com, mchehab@...nel.org,
 rric@...nel.org, loongarch@...ts.linux.dev
Subject: Re: [PATCH v2 2/2] Loongarch: EDAC driver for loongson memory
 controller

On 03/09/2024 13:31, Zhao Qunqin wrote:
> 
> 在 2024/9/3 下午7:29, Krzysztof Kozlowski 写道:
>> On 03/09/2024 10:30, Xi Ruoyao wrote:
>>> On Tue, 2024-09-03 at 09:58 +0200, Krzysztof Kozlowski wrote:
>>>>>>> +	select EDAC_SUPPORT
>>>>>> I think you got here comment before. How did you address it?
>>>>> I just randomly found a spot, and I will put it at the end(next version
>>>>> patch).
>>>> No, the comment was different. You must not select user-visible symbols.
>>> EDAC_SUPPORT isn't user-visible.  EDAC is and it has been removed.
>> Ah, ok, I missed that. Shouldn't this be separate patch with its own
>> rationale? Or before this driver there was no EDAC support for Loongson
>> at all?
> 
> Before this driver there was no EDAC support for Loongson
> at all.

Ack, ok.

Best regards,
Krzysztof